Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: remove firewalld on centos and fedora #1879

Closed
wants to merge 1 commit into from

Conversation

santigimeno
Copy link
Member

So it doesn't interfere with multicast tests.

Refs: libuv/libuv#2185

So it doesn't interfere with multicast tests.
@santigimeno
Copy link
Member Author

Any estimate when this could be included. It'll be great in order to have a greener libuv ci. Thanks!

@mhdawson
Copy link
Member

@santigimeno the challenge is that even once it lands it will only take effect once somebody runs it on all of the relevant machines. That I believe is a multi-hour job....

@rvagg
Copy link
Member

rvagg commented Aug 20, 2019

yes, sorry, this is near the top of my TODO list, haven't lost track of it, just need a bit of time to execute it with a clear head

@santigimeno
Copy link
Member Author

Ok. Thanks for the prompt response.

@vtjnash
Copy link

vtjnash commented Sep 16, 2019

Do you mind if I bump this?

@rvagg
Copy link
Member

rvagg commented Sep 17, 2019

don't mind at all, this had slipped low in my list! ... which is getting a bit out of hand again so I probably should dedicate a day or two to clearing my backlog. Will try and get to this soon.

@rvagg
Copy link
Member

rvagg commented Oct 21, 2019

with https://github.com/nodejs-private/secrets/pull/52 & #1977 this will be final, I merged this particular commit in 821de09 but it needed the additional cleanup in #1977 to run. It's been run against the fedora and centos hosts now and it appears to be working, see #1971

@rvagg rvagg closed this Oct 21, 2019
@santigimeno
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants