ansible: add ARM64 Windows machines #1795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if it works then rubber-stamp lgtm because I don't quite understand how this actually works against windows hosts |
joaocgreis
added a commit
that referenced
this pull request
May 16, 2019
Refs: #1780 PR-URL: #1795 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Thanks, landed in be6d6de |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #1780
This adds the public part of the inventory for two ARM64 Windows machines (secret parts already updated). This also adds two entries to the Windows configuration that previously were in
host_varsfiles, changes thevsvariable to be a string everywhere and adds ARM support to the Visual Studio 2017 installation (running on existing hosts won't add the new components to VS,cuninst -y visualstudio2017-workload-nativedesktopneeds to be run manually first).The machines are already online and connected to Jenkins.