Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Windows and Visual Studio supported versions #1407

Closed

Conversation

joaocgreis
Copy link
Member

This is a summary of supported versions for Windows and Visual Studio. This matches what is in the main Node repo for each version, but given the complexity of the matrix it's good to have this summarized in some place.

This is somewhat similar to #1149, but more focused on what we supported in the past. It may be good to merge both in the future, but for now it's probably better to let them mature separately.

cc @nodejs/build

gibfahn

This comment was marked as off-topic.

maclover7

This comment was marked as off-topic.

mhdawson

This comment was marked as off-topic.

kfarnung

This comment was marked as off-topic.

@refack
Copy link
Contributor

refack commented Jul 19, 2018

A few questions:

  1. Do we need to explicitly mention VCBT2015? (I don't remember if at the time any differences were found)? Maybe move it to a footnote (VS2015 & vs2017 support includes using the C++ Build Tools package
  2. RE doc: Windows building officially supported only on x64 hosts node#21443 we only test on 64 bit hosts, so maybe add a comment to that effect.
  3. VS2017 has a much more active release cycle, and there have been many public releases, so maybe add which version we use? Or suggest to always use latest version...

@joaocgreis
Copy link
Member Author

@refack I'd like to keep VCBT2015 separate there. Support was added separately from VS2015 and we use dedicated machines to test it. The VS2017 Build Tools have been almost issue-free (as other VS2017 editions), but VCBT2015 was more different from VS2015. I believe it's good to have it listed explicitly.

Updated about 2 & 3, PTAL.

refack

This comment was marked as off-topic.

joaocgreis added a commit that referenced this pull request Jul 24, 2018
PR-URL: #1407
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Kyle Farnung <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@joaocgreis
Copy link
Member Author

Landed in 639b55d

Thanks!

@joaocgreis joaocgreis closed this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants