Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api-prototype-6.2.0 fails to build #85

Closed
gabrielschulhof opened this issue Feb 3, 2017 · 0 comments
Closed

api-prototype-6.2.0 fails to build #85

gabrielschulhof opened this issue Feb 3, 2017 · 0 comments
Assignees
Milestone

Comments

@gabrielschulhof
Copy link
Collaborator

As of ae24137 I get

../src/node_jsvmapi.cc: In constructor ‘v8impl::CallbackWrapperBase<T, I>::CallbackWrapperBase(const T&)’:
../src/node_jsvmapi.cc:204:46: error: expected primary-expression before ‘>’ token
           _cbdata(cbinfo.Data().As<v8::Object>()) {
                                              ^
../src/node_jsvmapi.cc:204:48: error: expected primary-expression before ‘)’ token
           _cbdata(cbinfo.Data().As<v8::Object>()) {

when trying to build the branch.

gabrielschulhof pushed a commit to gabrielschulhof/abi-stable-node that referenced this issue Feb 3, 2017
@aruneshchandra aruneshchandra added this to the Milestone 4 milestone Feb 3, 2017
gabrielschulhof pushed a commit to gabrielschulhof/abi-stable-node that referenced this issue Feb 3, 2017
gabrielschulhof pushed a commit that referenced this issue Feb 4, 2017
gabrielschulhof pushed a commit that referenced this issue Feb 4, 2017
Fixes #85
Closes #87

(cherry picked from commit 8803b97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants