Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: imrpove is.date performance #4

Merged
merged 2 commits into from
Jul 19, 2017
Merged

feat: imrpove is.date performance #4

merged 2 commits into from
Jul 19, 2017

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jul 19, 2017

image

@fengmk2
Copy link
Member Author

fengmk2 commented Jul 19, 2017

性能提升还是挺恐怖的

* override core-util-is
*/

exports.date = function isDate(obj) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他的几个字符串判断的是不是也替换掉?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regexp 和 error

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯,我一个个来。我先合并不发布。

@fengmk2 fengmk2 merged commit 7ef4cd5 into master Jul 19, 2017
@fengmk2 fengmk2 deleted the performance branch July 19, 2017 05:29
fengmk2 added a commit to node-modules/hessian.js that referenced this pull request Aug 1, 2017
fengmk2 added a commit to node-modules/hessian.js that referenced this pull request Aug 1, 2017
fengmk2 added a commit to node-modules/hessian.js that referenced this pull request Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants