-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: imrpove is.date performance #4
Conversation
fengmk2
commented
Jul 19, 2017
性能提升还是挺恐怖的 |
* override core-util-is | ||
*/ | ||
|
||
exports.date = function isDate(obj) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其他的几个字符串判断的是不是也替换掉?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regexp 和 error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯,我一个个来。我先合并不发布。
avoid using toString() to type check - https://github.com/node-modules/hessian.js/pull/76/files#r117784718 - node-modules/is-type-of#4 - node-modules/is-type-of#5
avoid using toString() to type check - https://github.com/node-modules/hessian.js/pull/76/files#r117784718 - node-modules/is-type-of#4 - node-modules/is-type-of#5 pick from #80
avoid using toString() to type check - https://github.com/node-modules/hessian.js/pull/76/files#r117784718 - node-modules/is-type-of#4 - node-modules/is-type-of#5
avoid using toString() to type check - https://github.com/node-modules/hessian.js/pull/76/files#r117784718 - node-modules/is-type-of#4 - node-modules/is-type-of#5 pick from #80