Rename package.json extension to packageJson #232

node-gradle · Apr 22, 2023 · c9b8fa9 · c9b8fa9
1 parent 344638a
commit c9b8fa9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 # Changelog
 
-## Version 3.x *(unreleased)*
+## Version 4.x *(unreleased)*
+
+## Version 4.0.0 *(unreleased)*
+* Drop support for versions lower than Gradle 6.6
+* Rename `package.json` extension to `packageJson` [#232](https://github.com/node-gradle/gradle-node-plugin/issues/232)
 
 ## Version 3.6.0 *(2023-04-20)*
 * Allow task rules to be disabled [#116](https://github.com/node-gradle/gradle-node-plugin/issues/116)

diff --git a/src/main/kotlin/com/github/gradle/node/PackageJsonExtension.kt b/src/main/kotlin/com/github/gradle/node/PackageJsonExtension.kt
@@ -60,6 +60,6 @@ open class PackageJsonExtension(project: Project) {
         /**
          * Extension name in Gradle
          */
-        const val NAME = "package.json"
+        const val NAME = "packageJson"
     }
 }
diff --git a/src/test/groovy/com/github/gradle/node/PackageJsonExtensionTest.groovy b/src/test/groovy/com/github/gradle/node/PackageJsonExtensionTest.groovy
@@ -14,7 +14,7 @@ class PackageJsonExtensionTest extends AbstractProjectTest {
         project.evaluate()
 
         then:
-        def ext = project.extensions.getByName('package.json') as PackageJsonExtension
+        def ext = project.extensions.getByName(PackageJsonExtension.NAME) as PackageJsonExtension
         ext.name.get() == "test"
         ext.version.get() == "1.10.2"
         ext.private.get() == false
@@ -27,7 +27,7 @@ class PackageJsonExtensionTest extends AbstractProjectTest {
         """
         project.apply plugin: 'com.github.node-gradle.node'
         project.evaluate()
-        def ext = project.extensions.getByName('package.json') as PackageJsonExtension
+        def ext = project.extensions.getByName(PackageJsonExtension.NAME) as PackageJsonExtension
         ext.homepage.get() == null
 
         then:
@@ -43,7 +43,7 @@ class PackageJsonExtensionTest extends AbstractProjectTest {
         project.evaluate()
 
         then:
-        def ext = project.extensions.getByName('package.json') as PackageJsonExtension
+        def ext = project.extensions.getByName(PackageJsonExtension.NAME) as PackageJsonExtension
         ext.get("name") == "test"
         ext.getBoolean("private") == false
     }
@@ -59,7 +59,7 @@ class PackageJsonExtensionTest extends AbstractProjectTest {
         project.evaluate()
 
         then:
-        def ext = project.extensions.getByName('package.json') as PackageJsonExtension
+        def ext = project.extensions.getByName(PackageJsonExtension.NAME) as PackageJsonExtension
         ext.get("upper", "lower", "end") == "done"
     }
 }