Issue #100: remove the extension properties finalization that is usel…

…ess (explained in gradle/gradle#12974).
node-gradle · May 2, 2020 · b7693e9 · b7693e9
1 parent f3fe46c
commit b7693e9
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 19 deletions.
diff --git a/src/main/kotlin/com/github/gradle/node/NodeExtension.kt b/src/main/kotlin/com/github/gradle/node/NodeExtension.kt
@@ -25,22 +25,6 @@ open class NodeExtension(project: Project) {
         distBaseUrl.set("https://nodejs.org/dist")
     }
 
-    internal fun finalize() {
-        workDir.finalizeValue()
-        npmWorkDir.finalizeValue()
-        yarnWorkDir.finalizeValue()
-        nodeModulesDir.finalizeValue()
-        version.finalizeValue()
-        npmVersion.finalizeValue()
-        yarnVersion.finalizeValue()
-        distBaseUrl.finalizeValue()
-        npmCommand.finalizeValue()
-        npxCommand.finalizeValue()
-        npmInstallCommand.finalizeValue()
-        yarnCommand.finalizeValue()
-        download.finalizeValue()
-    }
-
     companion object {
         const val NAME = "node"
 

diff --git a/src/main/kotlin/com/github/gradle/node/NodePlugin.kt b/src/main/kotlin/com/github/gradle/node/NodePlugin.kt
@@ -23,9 +23,6 @@ class NodePlugin : Plugin<Project> {
         addTasks()
         addNpmRule()
         addYarnRule()
-        project.afterEvaluate {
-            nodeExtension.finalize()
-        }
     }
 
     private fun addGlobalTypes() {