Skip to content
This repository was archived by the owner on Nov 4, 2022. It is now read-only.

Cannot read property 'ssh_url' of null #436

Closed
robdodson opened this issue Apr 2, 2016 · 4 comments
Closed

Cannot read property 'ssh_url' of null #436

robdodson opened this issue Apr 2, 2016 · 4 comments
Labels
bug

Comments

@robdodson
Copy link

Just noticed this error this morning when I tried to use the gh pr 123 command.
Line 332 of pull-request.js seems to be breaking.

Running git version 2.8.0.rc2.
@henvic
Copy link
Member

henvic commented Apr 2, 2016

Hey @robdodson,

long time no see!

Please verify if the remote branch you are trying to pull still exists.

@brunofarache had a similar issue a 3-4 days ago due to the branch being removed from GitHub. I haven't submitted a fix for this yet (that would be adding a useful error message).

If the remote branch exists, please tell me if your remote is using SSH or HTTPS.

Best regards,
Henrique.

@robdodson
Copy link
Author

Yep the remote exists (it's the master branch). It's using HTTPS

@protoEvangelion
Copy link
Member

Someone on my team was getting an error as well when running gh pr number

Permission denied (publickey).
fatal: Could not read from remote repository.

The problem in this case was that they did not have ssh set up.

I added an option to disable ssh and use https instead via the ~/.gh.json config:

"ssh": false

protoEvangelion pushed a commit to protoEvangelion/gh that referenced this issue Oct 11, 2018
fix(pull-request): add option in config to use https instead of ssh
f35b84f 
fix node-gh#436
protoEvangelion pushed a commit to protoEvangelion/gh that referenced this issue Oct 11, 2018
fix(pull-request): add option in config to use https instead of ssh
56d3f8a 
fix node-gh#436
protoEvangelion pushed a commit to protoEvangelion/gh that referenced this issue Oct 11, 2018
fix(pull-request): add option in config to use https instead of ssh
1780146 
fix node-gh#436
protoEvangelion pushed a commit that referenced this issue Oct 11, 2018
chore(release): 1.13.5 [skip ci]
df6225f 
## [1.13.5](v1.13.4...v1.13.5) (2018-10-11)

### Bug Fixes

* **pull-request:** add option in config to use https instead of ssh ([7dac953](7dac953)), closes [#436](#436)
@protoEvangelion
Copy link
Member

🎉 This issue has been resolved in version 1.13.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@henvic @robdodson @protoEvangelion