Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

Drop the logger prefix? #340

Closed
henvic opened this issue Jan 9, 2015 · 0 comments
Closed

Drop the logger prefix? #340

henvic opened this issue Jan 9, 2015 · 0 comments

Comments

@henvic
Copy link
Member

henvic commented Jan 9, 2015

Currently we add a prefix (defaults to gh) to all lines sent to stdout.

I find it really nice because it's colorful (and reminds me of the irc bots / channels I used during my childhood 😀 ), but I've some good points against it:

  • no objective, measurable, real value
  • goes against the UNIX philosophy of doing one thing
  • complicates piping to other processes
  • it's a decorator based on taste, not a feature.
  • once I merge the changes of git.exec output git clone will show the progress bar (see Show git clone output #270) without it and it's going to feel inconsistent (adding it might be done, but not without sacrificing code quality and with the risk of side-effects).

Basics of the Unix Philosophy

What about just killing it with no mercy?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant