Add amdaie.flow for packet flow lowering
#815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtuyls
requested review from
makslevental,
MaheshRavishankar,
nirvedhmeshram,
yzhang93 and
Abhishek-Varma
as code owners
Abhishek-Varma
requested changes
Oct 2, 2024
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEAssignChannels.cpp
Outdated
Show resolved
Hide resolved
Comment on lines
48
to
49
| auto ui8ty = | ||
| IntegerType::get(rewriter.getContext(), 8, IntegerType::Unsigned); |
There was a problem hiding this comment.
Pull this out of the walk.
There was a problem hiding this comment.
Also please deposit $5 in the auto jar and please remove auto (yes I know I'm being a pedant...)
There was a problem hiding this comment.
Actually, here I think it's fine as the type is clear from the context. You see this all over IREE/LLVM and is okayed by the style guide we follow: https://google.github.io/styleguide/cppguide.html#Type_deduction
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIELowerToAIE.cpp
Outdated
Show resolved
Hide resolved
jtuyls
force-pushed
the
connection-to-flow
branch
from
72bedbe to
8a8f85f
Compare
Abhishek-Varma
approved these changes
Oct 2, 2024
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEAssignConnectionTypes.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEConnectionToFlow.cpp
Outdated
Show resolved
Hide resolved
jtuyls
force-pushed
the
connection-to-flow
branch
from
8a8f85f to
7382ded
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
amdaie.flowoperation (in consistency withaie.flow). This operation represents connections between ports/channels on tiles in the array and is lowered toaie.flowfor routing. This idea is to loweramdaie.connectiontoamdaie.flow+ DMA operations, however this PR goes halfway by creatingamdaie.flowoperations, while still keeping a reference insideamdaie.connectionas the latter is still needed insideLowerToAIEfor lowering to the AIE dialect DMA operations. This will be cleaned up in the future, but for now, this enables me to start adding routes for control packets in conjunction with data routes for #714.