Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FuseConsumerIntoLoop] Add support for fusing iteratively #1003

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

jtuyls
Copy link
Collaborator

@jtuyls jtuyls commented Dec 31, 2024

This PR adds support for iterative consumer fusion until no fusion opportunity can be found. See the test for an example in which this is needed: https://github.com/nod-ai/iree-amd-aie/compare/main...jtuyls:fuse-consumer-iters?expand=1#diff-df15abde86fbca464fa0a1e81b81bab2faaae00ea6a0aae73a9ba57477d78b05R471

Copy link
Contributor

@Abhishek-Varma Abhishek-Varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I have one proposal and one test related comment.

@jtuyls jtuyls force-pushed the fuse-consumer-iters branch from 7e6b941 to 1c63626 Compare January 2, 2025 10:39
@jtuyls jtuyls force-pushed the fuse-consumer-iters branch from 1c63626 to 4bf2912 Compare January 2, 2025 11:52
Copy link
Contributor

@Abhishek-Varma Abhishek-Varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jtuyls jtuyls enabled auto-merge (squash) January 2, 2025 12:12
@jtuyls jtuyls merged commit 39ae70d into nod-ai:main Jan 2, 2025
7 checks passed
@jtuyls jtuyls deleted the fuse-consumer-iters branch January 2, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants