Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct config.toml file handling on Windows #281

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

nieomylnieja
Copy link
Contributor

@nieomylnieja nieomylnieja commented Feb 3, 2025

Motivation

Currently, whenever modifying the config.toml file on Windows using sloctl config commands an error arises:

Error: rename C:\Users\mh.config\nobl9\config.toml3389036250 C:\Users\mh.config\nobl9\config.toml: The process cannot access the file because it is being used by another process.

The issue comes from Nobl9 SDK and is fixed by nobl9/nobl9-go#639.

Related changes

Testing

Tested on Windows 11 23H2 run inside Virtual Box.

image

Release Notes

sloctl config commands which modify config.toml should now work on Windows.

@n9-machine-user n9-machine-user added bug Something isn't working go patch labels Feb 3, 2025
@daniel-zelazny daniel-zelazny self-requested a review February 5, 2025 10:54
Copy link

@daniel-zelazny daniel-zelazny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@nieomylnieja nieomylnieja merged commit 6c90863 into main Feb 5, 2025
5 checks passed
@nieomylnieja nieomylnieja deleted the PC-15533-sloctl-windows-config-file-rename-fix branch February 5, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants