chore: address golangci-lint issues

[noahgorstein]

No description provided.

[ccoVeille]

This block intrigued me. I left it untouched knowing I would add golangci-lint, do it would be reported

[ccoVeille]

A TODO maybe

Also, you should write what was the issue, I mean the revive rules

I think its about code complexity

[noahgorstein]

yeah i definitely just punted on it for now while I come up with something more thoughtful.

[ccoVeille]

It's great that you started refactoring because of what golangci-lint reported. I assumed it was something about complexity.

I love linting because it allows to realize you can write better code.

[ccoVeille]

Maybe you could go back to 3 or 5, by simply adding //nolint:revive // this block is to complex for now. TODO refactorit later where needed

[noahgorstein]

Yeah I thought about staying at 5 or reverting to 3 but I was thinking about it and couldn't really come up with what the ideal number should be. For example, 3 feels low and for example I find a switch statement in the code with with 5 clauses with not lots of nested logic fairly readable but it would fail this linting check. I guess I could refactor it more to use like a map with keys that would be checked in the switch and values of functions to run but not sure that is any better in terms of readability/maintainability. I think in the very large switches with nested logic, that approach makes sense fwiw, but not on something I guess I would categorize as already readable/maintainable. wdyt?

[ccoVeille]

It's a matter of balance. You are the only one who can figure the right value here.

Having 8 sounds an high value to me, I prefer having code reported, but excluding with a nolint because they cannot be simplified than having a value too high.

Think about people who may contribute and come with spaghetti code that will go under the 8 value

[ccoVeille]

I would suggest rewriting it like that

       var processor  context.Context, *strings.Builder, *gojq.Query, []byte) error   = processJSONWithQuery
    
        if b.isJSONLines { 
             processor = processJSONLinesWithQuery
        }

         if err := processor(ctx, &results, query, b.inputdata.GetInputJSON()); err != nil { 
                   return "", err 
          } 
        
         return results.String(), nil

(pseudo code written on a phone)

[ccoVeille]

Same remark about a possible TODO to add here

[ccoVeille]

👍