-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to geoarrow 0.3. fixes #56 #59
Conversation
h3ronpy/pyproject.toml
Outdated
@@ -36,7 +36,7 @@ polars = [ | |||
"polars>=1.0" | |||
] | |||
pandas = [ | |||
"geopandas>=0.10", | |||
"geopandas>=1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@@ -21,8 +21,7 @@ spatial_index = ["dep:rstar"] | |||
[dependencies] | |||
ahash = "0.8" | |||
arrow = { workspace = true } | |||
# geoarrow = { package = "geoarrow", version = "0.1.0", optional = true, features = ["geozero"] } | |||
geoarrow = { package = "geoarrow", git = "https://github.com/geoarrow/geoarrow-rs.git", rev = "30c18f7c07432dfb92f9612efa54aec1d9392daf", optional = true, features = ["geozero"] } | |||
geoarrow = { version = "0.3", optional = true, features = ["geozero"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just published 0.4.0-beta.1 if you want to bump all the way up to that. You'll just have to take off the O
parameter.
But note there's also now a separation between "native" GeoArrow arrays and "serialized" GeoArrow arrays. WKB is a "serialized" array.
If you get stuck I'm happy to help update this code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am bit out of the loop on what is happening in the arrow-community. I remember the "native" geoarrow arrays where a bit problematic as there was no way to attach the metadata describing the geometrytype to the array. Is this now possible? Is it feasible to exchange the "native" arrays with other libraries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's not what I mean. I mean the GeoArrow format has both "Native encoding" and "Serialized encoding" https://geoarrow.org/format.html.
Previously in geoarrow-rs we had a single GeometryArrayTrait
that all geoarrow array types implemented, but now we have two:
NativeArray
, which is implemented byPointArray
,LineStringArray
,PolygonArray
,MultiPointArray
,MultiLineStringArray
,MultiPolygonArray
,MixedGeometryArray
, andGeometryCollectionArray
.SerializedArray
, which is implemented byWKBArray
andWKTArray
.
I just mean that you'll have to update the code to use these new traits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, now I got it ;)
BTW: Directly upgrading to geoarrow 0.4.0-beta.1 is not possible for me currently. This requires at least he release of rust-numpy built ontop of pyo3 0.22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also hoping that will come out very soon. PyO3/rust-numpy#442 (comment) and PyO3/rust-numpy#435 have been merged, which is very promising
No description provided.