Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace EOF with char_traits #4532

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Replace EOF with char_traits #4532

merged 2 commits into from
Dec 10, 2024

Conversation

nlohmann
Copy link
Owner

Fixes a regression of #2755

@nlohmann nlohmann self-assigned this Dec 10, 2024
@nlohmann nlohmann mentioned this pull request Dec 10, 2024
Closed
5 tasks
gregmarr
gregmarr approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@gregmarr gregmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to have the customers change in this PR as well?

@coveralls
Copy link

Coverage Status

coverage: 99.65%. remained the same
when pulling df5836c on eof
into 589641b on develop.

@nlohmann
Copy link
Owner Author

Did you intend to have the customers change in this PR as well?

Yes. A separate PR with pipeline seemed overkill.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Dec 10, 2024
@gregmarr
Copy link
Contributor

Agreed, just making sure it was intended.

@nlohmann nlohmann merged commit 20ae363 into develop Dec 10, 2024
122 checks passed
@nlohmann nlohmann deleted the eof branch December 10, 2024 19:51
slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
@nlohmann @slowriot
Replace EOF with char_traits (nlohmann#4532)
054c98c 
* 📝 update customers

* ♻️ replace EOF with char_traits nlohmann#2755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmarr gregmarr gregmarr approved these changes

Assignees

@nlohmann nlohmann

Labels
documentation M
Projects
None yet
Milestone
Release 3.11.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nlohmann @coveralls @gregmarr