fixed the issue of not handling when the user gets disconnected #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Override | ||
| public void run() { | ||
| if(!isConnected) { | ||
| mSocket.emit("add user", mUsername); |
There was a problem hiding this comment.
I think we have to check if mUsername exists ? since it would be null before login.
|
Yes you are correct, I inserted the check to see if username exists. |
|
thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used your demo app to create my own socket.io application which is when I found an issue in your app. When a user gets disconnected while chatting due to internet connection etc, even after socket is connected back the user cannot send any messages. In my commit I have handled that error. If you permit my commit to merge with yours it would help people a lot. Thank you for the demo app.