Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2595 Added null value handling in FieldValueMap #2596

Conversation

sbouchexbellomie-Philips

#2595 Added null value handling and use the same behaviour as for "null"

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2025

CLA assistant check
All committers have signed the CLA.

@sbouchexbellomie-Philips sbouchexbellomie-Philips changed the title #2595 Added null value handling #2595 Added null value handling in FieldValueMap Jan 21, 2025
@MrHinsh
Copy link
Member

MrHinsh commented Jan 24, 2025

Why close this? Did it not work?

@MrHinsh MrHinsh reopened this Jan 24, 2025
@MrHinsh
Copy link
Member

MrHinsh commented Jan 24, 2025

I reopened to run the build and see

@MrHinsh
Copy link
Member

MrHinsh commented Jan 24, 2025

@sbouchexbellomie-Philips looks like it passes. Can you confirm that you still want to close this?

@MrHinsh MrHinsh marked this pull request as draft January 27, 2025 10:50
@sbouchexbellomie-Philips sbouchexbellomie-Philips closed this by deleting the head repository Jan 28, 2025
@sbouchexbellomie-Philips
Copy link
Author

@MrHinsh Re-opened with a different account (legal reason)

@MrHinsh
Copy link
Member

MrHinsh commented Jan 28, 2025

That sounds like the contrived legal reason of a company lawyer :)

MrHinsh added a commit that referenced this pull request Jan 28, 2025
#2596 2595 Added null value handling and use the same behaviour as for
"null"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants