Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support author #91

Closed
wants to merge 5 commits into from
Closed

Support author #91

wants to merge 5 commits into from

Conversation

stepelu
Copy link

@stepelu stepelu commented Feb 20, 2022

Disclaimer: I can barely code in go and had no prior feed expertise.
This PR adds support for the author information, all 4 feed types are supported with (limited) testing.

More details:

  • author info is displayed below the date on the right pane when present
  • author info is searchable
  • HTML is stripped from author info
  • for RSS I allow both dc:creator and (non-conformant) author as the latter is still somewhat used in practice, dc:creator has priority

The search fts4 table has been modified accordingly, but clearly this is not done properly following the "migration" approach, so changes there are needed.
I am also unsure about the formatting / spacing in the structs I modified, please feel free to re-arrange.
I am aware of #57, I noticed the presence of the author column in the items table and went ahead with this modifications on my side as I needed them for my use case.
Please feel free to reject if this development is not desired.

@nkanaev
Copy link
Owner

nkanaev commented Mar 1, 2022

hi @stepelu. thanks for your efforts.

the author field was not included on purpose, as it:

  1. provided little to no value for personal feeds, as they contained only a single author
  2. required supporting multiple authors with corresponding metadata (name/url/avatar).

i do believe that having author information might be valuable for collective feeds, news feeds etc. but it's a little sacrifice i made. the main goal was to focus on the content itself & simplicity, rather than metadata information.

@nkanaev nkanaev closed this Mar 1, 2022
@stepelu
Copy link
Author

stepelu commented Mar 4, 2022

provided little to no value for personal feeds, as they contained only a single author

Usually it is the case.
My main use case for RSS is to follow up arXiv articles, like in:
http://arxiv.org/rss/cs.LG
There, being knowing who are the authors is key information (to determine whether to check an article further or not).

required supporting multiple authors with corresponding metadata (name/url/avatar).

I am not sure this is so important, especially as conveyed info depends on the feed type.

Either way it is fine. Maybe I'll make my customized version public at some point in the future in case it is useful for someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants