Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow passing args to node/npm/npx() #24

Merged
merged 1 commit into from
Apr 25, 2024
Merged

feat: allow passing args to node/npm/npx() #24

merged 1 commit into from
Apr 25, 2024

Conversation

lewis6991
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

Hello @lewis6991! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 29:80: E501 line too long (95 > 79 characters)
Line 35:80: E501 line too long (95 > 79 characters)

@lewis6991 lewis6991 mentioned this pull request Apr 25, 2024
Merged
njzjz
njzjz approved these changes Apr 25, 2024
View reviewed changes
Copy link
Owner

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@njzjz njzjz merged commit 6354cd7 into njzjz:master Apr 25, 2024
6 checks passed
@njzjz
Copy link
Owner

njzjz commented Apr 25, 2024

I just realized this PR might not achieve the expected behavior, as call_node raises SystemExit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njzjz njzjz njzjz approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewis6991 @pep8speaks @njzjz