Skip to content

Commit

Permalink
chore: quick updates
Browse files Browse the repository at this point in the history
  • Loading branch information
nixpig committed Dec 19, 2024
1 parent 1a209ca commit ce4ed44
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 6 deletions.
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# 🍪 brownie

**An experimental Linux container runtime, (mostly) implementing the [OCI Runtime Spec](https://github.com/opencontainers/runtime-spec/blob/main/spec.md).**
**An experimental Linux container runtime, implementing the [OCI Runtime Spec](https://github.com/opencontainers/runtime-spec/blob/main/spec.md).**

This is a personal project for me to explore and better understand the OCI Runtime Spec. It's not production-ready, and it probably never will be, but feel free to look around! If you're looking for a production-ready alternative to `runc`, take a look at [`youki`](https://github.com/containers/youki), which I think is pretty cool.

Expand All @@ -11,7 +11,6 @@ This is a personal project for me to explore and better understand the OCI Runti
**🗒️ To do** (items remaining for _me_ to consider this 'complete')

- [ ] ~Unit tests~ Integration tests seem to be sufficing
- [ ] Container cleanup
- [ ] Implement [Cgroups v2](https://github.com/opencontainers/runtime-spec/blob/main/config-linux.md#control-groups)
- [ ] Implement optional [Seccomp](https://github.com/opencontainers/runtime-spec/blob/main/config-linux.md#seccomp)
- [ ] Implement optional [AppArmor](https://github.com/opencontainers/runtime-spec/blob/main/config.md#linux-process)
Expand All @@ -22,7 +21,7 @@ This is a personal project for me to explore and better understand the OCI Runti
>
> This is an experimental project. It requires `sudo` and will make changes to your system. Take appropriate precautions.
I'm developing `brownie` on the following environment. Even with the same set up, YMMV. Maybe I'll create a Vagrant box in future.
I'm developing `brownie` on the following environment. Even with the same set up, YMMV.

**Development**
- `go version go1.23.0 linux/amd64`
Expand Down
1 change: 0 additions & 1 deletion container/container_delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ func (c *Container) Delete(force bool) error {
process.Signal(syscall.Signal(9))
}

// TODO: actually do the 'deleting'; rewind all the creation steps, not just deleting
if err := os.RemoveAll(filepath.Join(containerRootDir, c.ID())); err != nil {
return fmt.Errorf("delete container directory: %w", err)
}
Expand Down
1 change: 0 additions & 1 deletion container/container_kill.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ func (c *Container) Kill(sig syscall.Signal) error {
return fmt.Errorf("failed to save stopped state: %w", err)
}

// TODO: rollback and delete everything then...
if err := c.ExecHooks("poststop"); err != nil {
fmt.Println("Warning: failed to execute poststop hooks")
}
Expand Down
1 change: 0 additions & 1 deletion container/container_start.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ func (c *Container) Start() error {
}

if err := c.ExecHooks("prestart"); err != nil {
// TODO: rollback and delete (?), then...
if err := c.ExecHooks("poststop"); err != nil {
fmt.Println("Warning: failed to execute poststop hooks: ", err)
}
Expand Down

0 comments on commit ce4ed44

Please sign in to comment.