-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ohos): fix some compilation errors and add some features #2587
Conversation
And i use it to implement a simple traceroute, everything seems to be in order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review, thanks for the ping
Appreciate the explanation, it helps code review a lot!
APIs are not changed, but if you want, you can leave a changelog like this:
|
69196d3
to
3d9404b
Compare
Thanks for your review, i've already finished all of comments. Please see it again, thanks |
Regarding the changes in tests, does |
I am thinking about adding CI for:
Are you willing to do this after merging this PR? It is simple:
|
Unfortunately we can't run |
Sure, i'll add them later |
Get it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What does this PR do
This PR fix some compilation errors for OpenHarmony. I'll try to explain the following changes.
aio
andmqueue
should be hidden for OpenHarmony.memfd
, the following code is the content ofmemfd.h
:epoll.h
andeventfd.h
file, so i thinkepoll
andeventfd
can be used for OHOSThis PR don't change any nix's API, so i think i don't need to add a changelog right? Hope you can give me some suggestion thanks.
Checklist:
CONTRIBUTING.md