KEEPCNT/KEEPINTVL aren't available on OpenBSD. #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this commit, nix doesn't currently compile on OpenBSD. Some keepalive settings can be set globally, but not per-socket (see e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=970550 for some digging into this). Since it seems that NetBSD and DragonflyBSD have these settings, it makes more sense to only exclude them on OpenBSD rather than include them on (pretty much every) other operating systems.
|
Build succeeded: |
bors bot
added a commit
to softdevteam/snare
that referenced
this pull request
Oct 26, 2020
78: Update dependencies. r=vext01 a=ltratt There are some minor code changes necessary to deal with changes in hmac. [Note: currently nix 0.19.0 doesn't build on OpenBSD. A fix has been merged (nix-rust/nix#1318), but until a new release is made, snare's master branch won't build. Since I don't know how long that'll be, I think it's best to merge this now before it gets *too* stale, and pull in a nix fix later.] Co-authored-by: Laurence Tratt <[email protected]>
bors bot
added a commit
to softdevteam/snare
that referenced
this pull request
Oct 26, 2020
78: Update dependencies. r=vext01 a=ltratt There are some minor code changes necessary to deal with changes in hmac. [Note: currently nix 0.19.0 doesn't build on OpenBSD. A fix has been merged (nix-rust/nix#1318), but until a new release is made, snare's master branch won't build. Since I don't know how long that'll be, I think it's best to merge this now before it gets *too* stale, and pull in a nix fix later.] Co-authored-by: Laurence Tratt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this commit, nix doesn't currently compile on OpenBSD. Some keepalive settings can be set globally, but not per-socket (see e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=970550 for some digging into this). Since it seems that NetBSD and DragonflyBSD have these settings, it makes more sense to only exclude them on OpenBSD rather than include them on (pretty much every) other operating systems.