firefox: use policies.json to install extensions

[leo60228]

Description

This probably isn't the cleanest way to write this code, but it does work. The benefit of this over sideloading is that the extensions are automatically enabled, and there aren't any warnings. The DisableAppUpdate policy normally comes from the system policies.json, which we override.

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

  • Added myself and the module files to .github/CODEOWNERS.

[leo60228]

Emacs tests are failing, but that looks like it's completely unrelated.

[eyJhb]

Seems like we are doing the same, I am however using a patch for Firefox, to allow this #1436 , and doing some other stuff regarding extensions :)

Maybe we could combine it into one?

[leo60228]

Nixpkgs doesn't include Firefox betas, so I use Mozilla's Nix overlay, which wouldn't include this patch. I'd prefer it to be upstreamed.

…

On Tue, Aug 11, 2020, 5:01 PM eyJhb ***@***.***> wrote: Seems like we are doing the same, I am however using a patch for Firefox, to allow this #1436 <#1436> , and doing some other stuff regarding extensions :) Maybe we could combine it into one? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1434 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7X32MLYQ55H7XAZSBAFBLSAGWQ3ANCNFSM4PYWWKBQ> .

[eyJhb]

Not sure how that is related to what I wrote above, as what you are currently doing with XDG_RUNTIME_DIR is possible with the current Firefox in nixpkgs.

Still, not sure what that comments mean regards the two PRs for this functionality in HM

[leo60228]

I was referring to why I'd prefer the XDG_RUNTIME_DIR solution. It might've made more sense as a comment on your PR.

…

On Tue, Aug 11, 2020, 5:09 PM eyJhb ***@***.***> wrote: Not sure how that is related to what I wrote above, as what you are currently doing with XDG_RUNTIME_DIR is possible with the current Firefox in nixpkgs. Still, not sure what that comments mean regards the two PRs for this functionality in HM — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1434 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7X32PFE6XGQ2ICACHDYODSAGXQTANCNFSM4PYWWKBQ> .

[eyJhb]

Thinking of implementing both, as that would be fairly easy to give the choice :)

[eyJhb]

The same is now supported in the other PR, without all the rebuild, mkDerivation, etc. + individual policies if wanted.

[teto]

I will let @rycee comment on this since firefox configuration is his thing :D

[stale]

Thank you for your contribution! I marked this pull request as stale due to inactivity. If this remains inactive for another 7 days, I will close this PR. Please read the relevant sections below before commenting.

If you are the original author of the PR

• GitHub sometimes doesn't notify people who commented / reviewed a PR previously, when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
• If it is unfinished but you plan to finish it, please mark it as a draft.
• If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
• To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the issue

• If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

[leo60228]

I'm still using this myself, but it's probably best to rewrite it based on NixOS/nixpkgs#91724.