export nixosModule as file #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jan 9, 2025
| @@ -26,7 +26,7 @@ | |||
| in | |||
| { | |||
| nixosModules.default = self.nixosModules.disko; # convention | |||
| nixosModules.disko.imports = [ ./module.nix ]; | |||
| nixosModules.disko = ./module.nix; | |||
There was a problem hiding this comment.
What is the rational behind this? If we import modules by file they will have no _file defined. This means if disko is imported twice, there is not deduplication. Also error messages are worse.
There was a problem hiding this comment.
it seems this fixes multiple imports of the disko module, since it is a file it implicitly has _file defined
There was a problem hiding this comment.
The reason why the old code failed to import twice is because the file was imported into Nix manually making it an inline module as opposed to being imported as a file and having _file automatically defined
github-actions bot
pushed a commit
to clan-lol/clan-core
that referenced
this pull request
Jan 9, 2025
Include fix from nix-community/disko#934 The disko version before this makes the evaluation fail, if machines import their own disko directly already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.