cli: Fix "attribute missing" error when using flake #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #871 Previously, if a user used v2.10.0 (currently unreleased master), an error like this would be displayed: error: attribute '_cliDestroyFormatMount' missing at /nix/store/fbqgaij9d3b373rq1iav5glzr4dy77qf-disko/share/disko/cli.nix:73:7: 72| else if (lib.traceValSeq hasDiskoModuleFlake) then 73| (builtins.getFlake flake).nixosConfigurations.${flakeAttr}.config.system.build.${diskoAttr} | ^ 74| else This situation now produces a more helpful error: Error: Attribute `nixosConfigurations.testmachine.config.system.build._cliDestroyFormatMount` not found in flake `/home/felix/repos-new/disko`! This is probably caused by the locked version of disko in the flake being different from the version of disko you executed. EITHER set the `disko` input of your flake to `github:nix-community/disko/latest`, run `nix flake update disko` in the flake directory and then try again, OR run `nix run github:nix-community/disko/v1.9.0 -- --help` and use one of its modes.
The final config's attributes have different names than those defined in ./default.nix, so this failed previously.
iFreilicht
force-pushed
the
fix-disko-flake-compat-errr
branch
from
fb4b5de to
f4feab3
Compare
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at cb64993 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #871
Previously, if a user used v2.10.0 (currently unreleased master), an
error like this would be displayed:
This situation now produces a more helpful error:
Also, the final config's attributes have different names than those defined in ./default.nix, so even when updating the input on master did not fix this issue previously.