lvm_vg: fix size=100% leading to crash

[DavHau]

lvcreate -l does not accept a '100%' parameter which currently leads to a crash. THis change automatically changes 100% to 100%FREE leading to the intended behavior.

[phaer]

This feels a bit too magic from my perspective; I'd prefer failing loudly on non-supported values instead of preprocessing them like this.

While %FREE is probably the most commonly used suffix, it's not the same as "%" in other backends semantically. There's also %VG, %PVS and %ORIGIN.

Maybe it's good enough to just update the example to use 100%FREE?

[iFreilicht]

@phaer actually, sgdisk doesn't support 100% either. It uses -0, and we actively convert from 100% as a special value.

I do somewhat agree with your sentiment, the correct solution here is to fix this todo, but I think in the context of disko, being able to just use 100% for size everywhere is a nice, user-friendly abstraction for the most common usecase, so I am in support of this change.

I would like at least one other maintainer to agree on this, I don't wanna just merge something like this without some sort of consensus.

precedence with sgdisk

[phaer]

Thanks for noticing that @iFreilicht. Still not the biggest fan in terms of UX here, but I guess it's consistent then at least. So Lgtm!

[iFreilicht]

Alright, great!

[iFreilicht]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 58cd832