Fix disko using system zfs #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the |
|
Huh, indeed. I guess this is a bug in nixd then. |
iFreilicht
force-pushed
the
fix-disko-using-system-zfs
branch
from
734ce3a to
a60a461
Compare
|
Alright, I removed that commit again, should be good now. |
|
but removing |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at c8760ce |
iFreilicht
added a commit
that referenced
this pull request
Oct 16, 2024
This is generally regarded as a code-smell. I did utilize `with lib;` in some places where I felt it aided readability, but it's very clearly scoped in those situations. See #835 (comment)
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
This is generally regarded as a code-smell. I did utilize `with lib;` in some places where I felt it aided readability, but it's very clearly scoped in those situations. See #835 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #815
Also a drive-by improvement: The
with lib;was completely unused, so I removed it.@yajo FYI. Maybe you could test this again on the hetzner rescue system? I'm fairly confident it will work, but getting confirmation would be great.