Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap: fix partition type #834

Merged
merged 2 commits into from
Oct 16, 2024
Merged

swap: fix partition type #834

merged 2 commits into from
Oct 16, 2024

Conversation

iFreilicht
Copy link
Contributor

Fixes #391

@iFreilicht iFreilicht force-pushed the fix-swap-partition-type branch from 775880a to c488ee0 Compare October 14, 2024 22:19
@iFreilicht
Copy link
Contributor Author

iFreilicht commented Oct 14, 2024

Alright, this was a bit more complicated than I though, but it's done. The test currently requires the GUID of the dm-crypt partition type because lsblk doesn't print its name, see util-linux/util-linux#3238

I don't really like that I have to change something in gpt.nix that only affects the swap type, but I don't see another way to do it. Maybe it's possible to use parent somehow?

@iFreilicht iFreilicht force-pushed the fix-swap-partition-type branch from c488ee0 to 9b45005 Compare October 15, 2024 08:51
@iFreilicht
Copy link
Contributor Author

Removed the "Linux dm-crypt" type again based on the explanation in the issue I linked above. From my side, this is ready for review.

@Mic92
Copy link
Member

Mic92 commented Oct 16, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Oct 16, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at dcabcca

@mergify mergify bot merged commit dcabcca into master Oct 16, 2024
4 checks passed
@mergify mergify bot deleted the fix-swap-partition-type branch October 16, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disko sets the wrong partition type for the swap partition
2 participants