disko-install: make output deterministic #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright I had time to properly test this now, and it works! On master: # sudo nix run '.#disko-install' -- --dry-run --disk main /dev/asdf --flake '.#testmachine'
these 2 derivations will be built:
/nix/store/1dxaxs72mgm3f989225hgs9w0l209cwm-disko.drv
/nix/store/iyjdzd298y7hh2vdgn9nrqlrknzqiy64-disko.drv
building '/nix/store/1dxaxs72mgm3f989225hgs9w0l209cwm-disko.drv'...
building '/nix/store/iyjdzd298y7hh2vdgn9nrqlrknzqiy64-disko.drv'...
Would run: /nix/store/kgmcj274zh83yb7gwadvymsv69zzkhl5-disko
Would run: nixos-install --system '/nix/store/b20shmmwlg1np3hflxjklm58a77gsnrs-nixos-system-disko-machine-24.11.20240901.b833ff0' --root '/tmp/tmp.1soo4VO6rU'
# sudo nix run '.#disko-install' -- --dry-run --disk main /dev/asdf --flake '.#testmachine'
these 2 derivations will be built:
/nix/store/456549r013s5dpa7fpjvlbgk3dyd465d-disko.drv
/nix/store/i1xfmwrj4b74x9gwryparyq4x0a954gm-disko.drv
building '/nix/store/456549r013s5dpa7fpjvlbgk3dyd465d-disko.drv'...
building /nix/store/i1xfmwrj4b74x9gwryparyq4x0a954gm-disko.drv'...
Would run: /nix/store/0ma5r0swjwc4xsgx4s06pi9q8s6241y6-disko
Would run: nixos-install --system '/nix/store/b20shmmwlg1np3hflxjklm58a77gsnrs-nixos-system-disko-machine-24.11.20240901.b833ff0' --root '/tmp/tmp.SGnbALeYr4'On this branch: # sudo nix run '.#disko-install' -- --dry-run --disk main /dev/asdf --flake '.#testmachine'
these 2 derivations will be built:
/nix/store/j185c9vxblajx27biygfpw5kqk0lzlfa-disko.drv
/nix/store/q7wf7y4xqahvrifwyssxmsy6v64rkk49-disko.drv
building '/nix/store/j185c9vxblajx27biygfpw5kqk0lzlfa-disko.drv'...
building '/nix/store/q7wf7y4xqahvrifwyssxmsy6v64rkk49-disko.drv'...
Would run: /nix/store/vj7mdgcki9l4wdnfyp4dfswns2hlk5nd-disko
Would run: nixos-install --system '/nix/store/b20shmmwlg1np3hflxjklm58a77gsnrs-nixos-system-disko-machine-24.11.20240901.b833ff0' --root '/mnt/disko-install-root'
# sudo nix run '.#disko-install' -- --dry-run --disk main /dev/asdf --flake '.#testmachine'
Would run: /nix/store/vj7mdgcki9l4wdnfyp4dfswns2hlk5nd-disko
Would run: nixos-install --system '/nix/store/b20shmmwlg1np3hflxjklm58a77gsnrs-nixos-system-disko-machine-24.11.20240901.b833ff0' --root '/mnt/disko-install-root' |
iFreilicht
force-pushed
the
fix-disko-install-non-determinism
branch
from
49d17a9 to
a45dd8f
Compare
Enzime
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #827
@matdibu FYI