Add binlore for disko and disko-install #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 23, 2024
Consider this flake:
{
description = "Helper for reproducing a disko-related problem";
inputs = {
disko.url = "github:nix-community/disko/b1d6bed240abef5f5373e88fc7909f493013e557";
nixpkgs.follows = "disko/nixpkgs";
};
outputs =
{
self,
disko,
nixpkgs,
}:
let
system = "x86_64-linux";
pkgs = nixpkgs.legacyPackages."${system}";
in
{
packages."${system}".default =
pkgs.resholve.writeScript "disko-install-binlore-test"
{
inputs = [ disko.packages."${system}".default ];
interpreter = "${pkgs.lib.getExe pkgs.bash}";
}
''
disko --help
disko-install --help
'';
};
}
That flake will fail to build because resholve thinks that disko and
disko-install might be able to execute their arguments. This commit
fixes that problem.
Co-authored-by: Jörg Thalheim <[email protected]>
|
@Jayman2000 I'm currently updating the package in nixpkgs. Is it necessary to add |
|
It’s not necessary, but it would definitely be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message for details. Also, you might want to view this PR’s commit with
git show --word-diff. GitHub’s diff for this commit is kind of hard to read.