make-disk-image: convert into NixOS module #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `makeDiskImages` always requires a NixOS configuration, we can simplify the code by convering it into a NixOS module. Then we can make it responsible for populating `system.build.diskoImages` and `system.build.diskoImagesScript`.
Enzime
force-pushed
the
refactor/make-disk-image
branch
from
ace113a to
cc4d4a4
Compare
Lassulus
approved these changes
Sep 15, 2024
colemickens
reviewed
Sep 15, 2024
Comment on lines
106
to
112
| memSize = lib.mkOption { | ||
| type = lib.types.int; | ||
| description = '' | ||
| size of the memory passed to runInLinuxVM, in megabytes | ||
| ''; | ||
| default = 1024; | ||
| }; |
There was a problem hiding this comment.
should memSize have been moved, too?
There was a problem hiding this comment.
I didn't move it because it's being shared by interactive VM:
Line 59 in 51e3a7e
Maybe the comment needs updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
makeDiskImagesalways requires a NixOS configuration, we can simplify the code by converting it into a NixOS module. Then we can make it responsible for populatingsystem.build.diskoImagesandsystem.build.diskoImagesScript.