zfs_fs: support updating mountpoint properly #762
Conversation
|
@iFreilicht could you test if this change works on your system? @Mic92 @Lassulus now that |
It's meant to run from a installer or in-memory system that doesn't depend on the disks. However ideally it could also unmount disks as needed to perform the operation. |
Don't have access right now, will do next week. Feel free to ping me again if I didn't reply by next Wednesday. |
|
@iFreilicht out of curiosity, were you running the format script on an online machine or an offline one? |
|
I ran on an online system if by online you mean "already installed and with drives mounted". |
Enzime
force-pushed
the
zfs-set-mountpoint
branch
2 times, most recently
from
75870f2 to
692ac92
Compare
|
@Mic92 any idea why |
|
@Enzime they seem to succeed now, but |
|
@Mic92 yeah that check succeeds locally for me |
Use `zfs set -u` to update the `mountpoint` flag without mounting or unmounting the filesystem. This flag was added in OpenZFS 2.2.0, which was released October 2023. The previous logic would not update `mountpoint` if `config.options` was empty or only contained `mountpoint`.
Enzime
force-pushed
the
zfs-set-mountpoint
branch
from
f73e532 to
754dff2
Compare
|
@Mic92 is there a way to trigger it to run again? I'm wondering if it's a flaky test |
|
I can login into buildbot with github on the overview and then retrigger it, but maybe that's one of my undocumented superpowers I forgot about |
|
We just need to invite you to the nix-community org and then you can trigger rebuilds |
|
Invite sent. |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d32d150 |
Use
zfs set -uto update themountpointflag without mounting or unmounting the filesystem. This flag was added in OpenZFS 2.2.0, which was released October 2023.The previous logic would not update
mountpointifconfig.optionswas empty or only containedmountpoint.