types btrfs: fix format without swap or subvolumes #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lassulus
reviewed
Apr 8, 2024
|
it would also be nice to have an example config and a test which triggers that error. so we can detect regressions in the future :) |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 79eab0e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Recently when trying to format a btrfs drive I ran into
syntax error near unexpected token `fi'.It looks like #568 introduced a change that generates an empty if statement if neither the swap config or subvolumes are set and this just adds a guard to avoid adding that empty if block if neither are set.