Allow users to configure default git branch name #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
(See #205 (comment)) |
|
I had the same issue, but the root cause seems to be that the branch parameter in cargo is simply ignored by crate2nix and it's not the problem with the defaults. |
|
@QAston sorry I didn't respond sooner, are you saying this fix is insufficient on its own? |
|
Yes, I think so. Might be a different problem though - my cargo file pointed to the correct branch but it was ignored by cargo.nix, maybe in the OP's case there was no branch set in cargo files. |
|
Heyo @QAston / @Ericson2314, I am doing some clean up work... I guess we can close this? |
|
(otherwise reopen) |
|
no idea, I moved on from nix, I hope I never have to go back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.