fix: getent missing in syschdemd #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
approved these changes
Jul 12, 2023
| @@ -43,7 +43,7 @@ mkWrappedScript { | |||
| "/run/wrappers" # mount | |||
| coreutils | |||
| daemonize | |||
| glibc # getent | |||
| getent | |||
There was a problem hiding this comment.
we could also use glibc.getent but using getent is more cross friendly even if that does not matter here https://github.com/NixOS/nixpkgs/blob/3a671cd64d03f4e55eb6c817d6294910e0ccc133/pkgs/top-level/unixtools.nix#L74-L78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the discussion in #237 (though it doesn't address the original issue, so don't close that after merging this)
getentwas moved to its own derivation and removed fromglibcon unstable. Therefore syschdemd crashed on systems running nixos-unstable. By using the getent derivation instead, it works on 22.11, 23.05 and unstable (that's the ones I tested, it might work on older versions as well)