Skip to content

Add support for OAR Scheduler #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

ychiat35
Copy link

@ychiat35 ychiat35 commented Oct 16, 2023

Types of changes

  • New feature (non-breaking change which adds functionality)

Summary

The Oar scheduler is widely used in France, including mesocentre supercomputers (e.g., GRICAD), INRIA supercomputers, Grid5000 testbed and other platforms.

This PR adds support for the OAR Scheduler, following the implementation made for Slurm.

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: Patch coverage is 21.63743% with 134 lines in your changes missing coverage. Please review.

Project coverage is 88.11%. Comparing base (55c30c1) to head (7d021bb).

Files with missing lines Patch % Lines
pydra/workers/oar.py 21.31% 95 Missing and 1 partial ⚠️
pydra/workers/tests/test_worker.py 20.83% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
- Coverage   88.75%   88.11%   -0.64%     
==========================================
  Files          84       85       +1     
  Lines       17891    18062     +171     
  Branches     3487     3525      +38     
==========================================
+ Hits        15879    15916      +37     
- Misses       1642     1774     +132     
- Partials      370      372       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djarecka
Copy link
Collaborator

djarecka commented Nov 3, 2023

@ychiat35 - thank you for adding this worker. Would it be possible to test it within a container?

@ychiat35 ychiat35 force-pushed the feature/oar branch 9 times, most recently from ea8a805 to f7d9e79 Compare November 14, 2023 16:23
@ychiat35 ychiat35 force-pushed the feature/oar branch 3 times, most recently from 6856bfb to e54491c Compare November 21, 2023 16:07
@ychiat35
Copy link
Author

@ychiat35 - thank you for adding this worker. Would it be possible to test it within a container?

Hi, I'm trying to use oar-docker to do that. It is still WIP (I have to find more time doing that) but I noticed that the oar-docker solution requires cgroup v1, so I have to run on ubuntu-20.04 but not ubuntu-latest. Is this a problem for you?

@tclose
Copy link
Contributor

tclose commented Apr 1, 2025

Did you ever get this working? Should I try to port it to the new structure

@tclose tclose added the to consider suggesting changes that require more discussion label Apr 2, 2025
@github-project-automation github-project-automation bot moved this to In progress in Pydra Roadmap Apr 29, 2025
@tclose tclose removed the to consider suggesting changes that require more discussion label Apr 29, 2025
@ychiat35 ychiat35 marked this pull request as draft April 29, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

4 participants