Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Apply ruff/flake8-pie rules (PIE) #3678

Merged
merged 5 commits into from
Oct 6, 2024
Merged

Conversation

DimitriPapadopoulos
Copy link
Contributor

Summary

Apply flake8-pie (PIE) rules, except:

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 70.84%. Comparing base (e03ab6f) to head (3980037).
Report is 176 commits behind head on master.

Files with missing lines Patch % Lines
nipype/interfaces/cmtk/cmtk.py 0.00% 2 Missing ⚠️
nipype/interfaces/dcm2nii.py 0.00% 2 Missing ⚠️
nipype/algorithms/misc.py 0.00% 1 Missing ⚠️
nipype/interfaces/cmtk/nx.py 0.00% 1 Missing ⚠️
nipype/interfaces/dipy/simulate.py 0.00% 1 Missing ⚠️
nipype/interfaces/freesurfer/preprocess.py 0.00% 1 Missing ⚠️
nipype/interfaces/freesurfer/utils.py 0.00% 0 Missing and 1 partial ⚠️
...ne/plugins/tests/test_legacymultiproc_nondaemon.py 0.00% 1 Missing ⚠️
nipype/utils/filemanip.py 0.00% 1 Missing ⚠️
nipype/utils/nipype2boutiques.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3678   +/-   ##
=======================================
  Coverage   70.83%   70.84%           
=======================================
  Files        1276     1276           
  Lines       59320    59313    -7     
  Branches     9826     9826           
=======================================
- Hits        42019    42018    -1     
+ Misses      16125    16119    -6     
  Partials     1176     1176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PIE790 Unnecessary `pass` statement
PIE804 Unnecessary `dict` kwargs
PIE808 Unnecessary `start` argument in `range`
PIE810 Call `endswith` once with a `tuple`
PIE810 Call `endswith` once with a `tuple`
@effigies effigies merged commit 72a944e into nipy:master Oct 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants