Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update niworkflows version to 1.11.0 #478

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jhlegarreta
Copy link
Contributor

Update niworkflows version to 1.11.0.

Fixes:

(sdcflows) root@91f133b4405b:/tmp# sdcflows /bids-input /bids-output participant --debug
241030-17:10:41,542 cli IMPORTANT:
	 Running SDCFlows 2.10.0:
             * BIDS dataset path: /bids-input.
             * Output folder: /bids-output.
             * Analysis levels: ['participant'].

Traceback (most recent call last):
  File "/opt/conda/envs/sdcflows/bin/sdcflows", line 8, in <module>
    sys.exit(main())
  File "/opt/conda/envs/sdcflows/lib/python3.10/site-packages/sdcflows/cli/main.py", line 178, in main
    "plugin": MultiProcPlugin(
  File "/opt/conda/envs/sdcflows/lib/python3.10/site-packages/niworkflows/engine/plugin.py", line 416, in __init__
    from mriqc import config
ModuleNotFoundError: No module named 'mriqc'

reported by GitHub user @miltoncamacho.

Update requirements.txt and min-requirements.txt by running .maint/update_requirements.py.

Fixes #468.

Update `niworkflows` version to 1.11.0.

Fixes:
```
(sdcflows) root@91f133b4405b:/tmp# sdcflows /bids-input /bids-output participant --debug
241030-17:10:41,542 cli IMPORTANT:
	 Running SDCFlows 2.10.0:
             * BIDS dataset path: /bids-input.
             * Output folder: /bids-output.
             * Analysis levels: ['participant'].

Traceback (most recent call last):
  File "/opt/conda/envs/sdcflows/bin/sdcflows", line 8, in <module>
    sys.exit(main())
  File "/opt/conda/envs/sdcflows/lib/python3.10/site-packages/sdcflows/cli/main.py", line 178, in main
    "plugin": MultiProcPlugin(
  File "/opt/conda/envs/sdcflows/lib/python3.10/site-packages/niworkflows/engine/plugin.py", line 416, in __init__
    from mriqc import config
ModuleNotFoundError: No module named 'mriqc'
```

reported by GitHub user @miltoncamacho.

Update `requirements.txt` and `min-requirements.txt` by running
`.maint/update_requirements.py`.

Co-authored-by: miltoncamacho <[email protected]>
@jhlegarreta
Copy link
Contributor Author

Supersedes #469.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (50c053d) to head (af434a2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #478   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files          30       30           
  Lines        2819     2819           
  Branches      365      365           
=======================================
  Hits         2364     2364           
  Misses        384      384           
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 3828bf0 into nipreps:master Jan 22, 2025
18 checks passed
@jhlegarreta jhlegarreta deleted the BumpNiworkflows branch January 22, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI run requires mriqc to be installed
3 participants