Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Set up customized report specification #34

Merged
merged 10 commits into from
Dec 13, 2019
Merged

ENH: Set up customized report specification #34

merged 10 commits into from
Dec 13, 2019

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Nov 2, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 2, 2019

Codecov Report

Merging #34 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   40.43%   40.37%   -0.07%     
==========================================
  Files           9        9              
  Lines         591      592       +1     
  Branches       93       93              
==========================================
  Hits          239      239              
- Misses        351      352       +1     
  Partials        1        1
Impacted Files Coverage Δ
dmriprep/cli/run.py 28.91% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7c8a6...3b71547. Read the comment docs.

@oesteban oesteban marked this pull request as ready for review November 3, 2019 15:26
@oesteban oesteban requested a review from josephmje November 3, 2019 15:26
@oesteban
Copy link
Member Author

oesteban commented Nov 3, 2019

Great work @josephmje on this one!. I'll merge as soon as we get a new release of niworkflows (that's the reason for the one test failing).

@josephmje
Copy link
Collaborator

Great work @josephmje on this one!. I'll merge as soon as we get a new release of niworkflows (that's the reason for the one test failing).

I was just about to ask whether I should be concerned by the failed test. But looks like the anatomical workflows run now!

@josephmje
Copy link
Collaborator

With the new version of niworkflows, it looks like BIDSDataGrabberOutputSpec has changed to _BIDSDataGrabberOutputSpec in dmriprep/interfaces/__init__.py

@pull-assistant
Copy link

pull-assistant bot commented Dec 12, 2019

Score: 0.85

Best reviewed: commit by commit


Optimal code review plan (2 warnings)

initial reportlet creation

MANIFEST.in 50% changes removed in apply Oscar's sugges...

     minor fix

     use dmriprep reports module

     fix formatting

     remove duplicated code

apply Oscar's suggestions

MANIFEST.in 50% changes removed in pin(niworkflows): te...

dmriprep/config/report.tpl 43% changes removed in pin(niworkflows): te...

setup.cfg 50% changes removed in pin(niworkflows): te...

     pin(niworkflows): test out new report generation change and rebase

     Update setup.cfg

     fix: clean up nilearn

     Merge branch 'master' into enh/reportlet

Powered by Pull Assistant. Last update 46bee56 ... 2e8aadf. Read the comment docs.

@oesteban
Copy link
Member Author

Okay, this seems to be working okay and the integration also works fine in fMRIPrep land - I'm going for it.

@oesteban oesteban merged commit 5282950 into nipreps:master Dec 13, 2019
@oesteban oesteban deleted the enh/reportlet branch December 13, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants