Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Use new DerivativesDataSink from NiWorkflows 1.2.0 #108

Merged
merged 1 commit into from
May 7, 2020

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented May 3, 2020

This PR integrates the new API that will be released with 1.2.0.

References: nipreps/niworkflows#507

@oesteban oesteban requested a review from josephmje May 3, 2020 15:22
@pull-assistant
Copy link

pull-assistant bot commented May 3, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     enh: use new DerivativesDataSink from NiWorkflows 1.2.0

Powered by Pull Assistant. Last update de14073 ... de14073. Read the comment docs.

@oesteban oesteban force-pushed the enh/new-datasinks branch from 1772175 to bb2d806 Compare May 3, 2020 15:25
@codecov
Copy link

codecov bot commented May 3, 2020

Codecov Report

Merging #108 into master will increase coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   51.88%   51.92%   +0.04%     
==========================================
  Files          20       20              
  Lines        1222     1221       -1     
  Branches      161      161              
==========================================
  Hits          634      634              
+ Misses        576      575       -1     
  Partials       12       12              
Impacted Files Coverage Δ
dmriprep/cli/run.py 4.10% <ø> (ø)
dmriprep/cli/workflow.py 2.94% <ø> (ø)
dmriprep/workflows/base.py 22.89% <0.00%> (ø)
dmriprep/workflows/dwi/base.py 44.44% <0.00%> (+2.33%) ⬆️
dmriprep/workflows/dwi/outputs.py 38.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2df371...de14073. Read the comment docs.

@oesteban oesteban force-pushed the enh/new-datasinks branch from bb2d806 to 78f7369 Compare May 3, 2020 20:59
@oesteban oesteban force-pushed the enh/new-datasinks branch from 78f7369 to de14073 Compare May 7, 2020 18:27
@oesteban oesteban marked this pull request as ready for review May 7, 2020 20:27
@oesteban
Copy link
Member Author

oesteban commented May 7, 2020

@josephmje any concerns?

Copy link
Collaborator

@josephmje josephmje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for this.

@oesteban oesteban merged commit 25a20ba into nipreps:master May 7, 2020
@oesteban oesteban deleted the enh/new-datasinks branch May 7, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants