prevent user from sending empty messages #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nioc
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Hello @haansn08.
Thanks for the PR.
Could you fix the lint errors before merging?
Error: 82:42 error Expected '===' and instead saw '==' eqeqeq
Error: 83:1 error Expected indentation of 10 spaces but found 12 indent
Error: 84:1 error Expected indentation of 10 spaces but found 12 indent
|
🚀 @haansn08 your code is released in 0.10.3. |
|
Wow a whole release for this PR! 😳️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if
hasSendingEnterKeyis enabled, it is possible to mistakenly send an empty message or spam the room with empty messages simply by keeping Enter pressed. This PR prevents sending a message, when the input is empty.