Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: add a verbose mode #882

Merged
merged 1 commit into from
Dec 11, 2014
Merged

Conversation

mathstuf
Copy link
Contributor

Required for Fedora infrastructure so that the commands used to build
ninja are logged.


Port of #265 to the new configure.py script.

Required for Fedora infrastructure so that the commands used to build
ninja are logged.
nico added a commit that referenced this pull request Dec 11, 2014
@nico nico merged commit 27ece46 into ninja-build:master Dec 11, 2014
@nico
Copy link
Collaborator

nico commented Dec 11, 2014

Thanks!

It's a bit strange that this only has an effect in bootstrap mode, but I couldn't think of anything better. (It could be --bootstrap and --bootstrap=verbose, but that's strange too.)

@mathstuf mathstuf deleted the verbose-configure branch December 11, 2014 05:18
@mathstuf
Copy link
Contributor Author

What else would it output? "wrote build.ninja"? Maybe a list of files it thinks are important and re2c detection?

@nico
Copy link
Collaborator

nico commented Dec 11, 2014

I don't think it should print more. It just feels a bit strange that there's a flag (that shows up in -help and all) that has no visible effect unless you pass another flag too.

@mathstuf
Copy link
Contributor Author

Ah, I see now. I see it as "the only place where there is currently code to be verbose about is during bootstrap". There's certainly nothing stopping it from having effects other than bootstrap (but is the place it makes the most sense). I guess the other place that it would make sense is in has_re2c where you might want to print the version found. The rest is mainly just writing out the initial build.ninja file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants