do not unconditionally use PATH_MAX with getcwd #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, grow a buffer until getcwd either succeeds or fails with an errno different than ERANGE (meaning the passed buffer was too short to represent the actual path). Reset errno before calling getcwd to check it eventually did not fail.
|
Evan Martin » ninja #469 SUCCESS |
|
Looking through the code, I see some other mentions of MAX_PATH -- do you know about the portability of that? |
|
After my changes, the only PATH_MAX occurrency I see is in src/util.h, in a #ifdef _MSC_VER block -- possibly no more useful, but I have no Windows environment to test its removal. |
|
Right, I'm talking about MAX_PATH, not PATH_MAX. It's very confusing, which is why I'm asking you. :) |
|
From what I know, MAX_PATH is nothing standard and just provided on Windows. |
evmar
added a commit
that referenced
this pull request
May 23, 2013
do not unconditionally use PATH_MAX with getcwd
|
Thanks for the patch! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, grow a buffer until getcwd either succeeds or fails with an errno different than ERANGE
(meaning the passed buffer was too short to represent the actual path).
Reset errno before calling getcwd to check it eventually did not fail.
This fixes a build failure on GNU/Hurd, which does not provide PATH_MAX (which is optional in POSIX).