Ninja -t browse opens localhost in browser, which doesn't work when using ssh #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Evan Martin » ninja #249 FAILURE |
|
Evan Martin » ninja #276 SUCCESS |
|
Evan Martin » ninja #473 SUCCESS |
… using ssh Change-Id: Ic4be6527151a7ff68afab62e61951071ad5694b7
|
Updated to ninja 1.3 |
|
Evan Martin » ninja #474 SUCCESS |
|
Sorry I dropped this! |
evmar
added a commit
that referenced
this pull request
May 23, 2013
Ninja -t browse opens localhost in browser, which doesn't work when using ssh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browse tool should use the real hostname not http://localhost, to allow -t browse when using ssh
Fix attached.