Minor `std/strscans` improvements #24566

ire4ever1190 · 2024-12-24T23:24:17Z

e.g. this would emit a warning

import std/strscans

proc main() =
  let (ok, number) = "123".scanTuple()

import std/strscans

var str: string
discard "123".scanf("$i", str)

it gave this warning before

now it returns

github-actions · 2024-12-25T08:31:31Z

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 5b9ff96

Hint: mm: orc; opt: speed; options: -d:release
178147 lines; 8.716s; 653.848MiB peakmem

#### Removes UnInit warnings when using `scanTuple` e.g. this would emit a warning ```nim import std/strscans proc main() = let (ok, number) = "123".scanTuple() ``` ![image](https://github.com/user-attachments/assets/68170ac6-402d-48b0-b8b6-69e71f4b70ae) #### Error for wrong type now points to the passed in variable ```nim import std/strscans var str: string discard "123".scanf("$i", str) ``` it gave this warning before ![image](https://github.com/user-attachments/assets/096e56d2-0eb5-4c67-9725-25caa97afebd) now it returns ![image](https://github.com/user-attachments/assets/736a4292-2f56-4cf3-a27a-677045377171) (cherry picked from commit 5b9ff96)

ire4ever1190 added 3 commits December 25, 2024 08:13

Make the error point to the variable in the user code

1449a79

Make sure the variables are initialised to remove Uninit warning

e2e97ef

Fix up the expected file in test

0a914d3

Araq merged commit 5b9ff96 into nim-lang:devel Dec 25, 2024
18 checks passed

ire4ever1190 deleted the fix/strscans-warnings branch December 25, 2024 09:21

Provide feedback