fixes #23114; Nim v2 regression emit / asm var param dereference inconsistency #24547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It breaks stint: https://github.com/status-im/nim-stint/blob/c5a4355407551804bb4e15aa6cf8dbd881b944a3/stint/private/primitives/extended_precision_x86_64_gcc.nim#L53 => status-im/nim-stint#164 Since it's a hidden deref from var param, it is most likely breaking at compilation time |
ringabout
added a commit
to ringabout/nim-stint
that referenced
this pull request
Dec 18, 2024
In nim-lang/Nim#24547, asm statements require no explicit dereference
|
I will make it a legacy feature to use unchecked |
arnetheduck
pushed a commit
to status-im/nim-stint
that referenced
this pull request
Dec 19, 2024
In nim-lang/Nim#24547, asm statements require no explicit dereference
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23114
As in #22074, expressions in bracketed emit are strictly typechecked, this PR applies the same check for symbols in asm statements in order to keep them consistent.