#Fixes #24536 building nimble 0.16.4 fails when running build_all.sh #24537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These scripts were generated:
|
ups |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
31 tasks
Buldram
added a commit
to Buldram/spack
that referenced
this pull request
Dec 16, 2024
Omitting --skipParentCfg necessary after: nim-lang/Nim#24437 Build script patch in Nim repo: nim-lang/Nim#24537
Buldram
added a commit
to Buldram/spack
that referenced
this pull request
Dec 16, 2024
Omitting --skipParentCfg is necessary after: nim-lang/Nim#24437 Build script patch in Nim repo: nim-lang/Nim#24537
|
This is still not properly fixed. |
|
I will fix it for nightlies |
Araq
pushed a commit
that referenced
this pull request
Dec 17, 2024
) follow up #24537 Because `nimble` is a bundled repo so it is bundled in the tarballs i.e. https://github.com/nim-lang/nightlies/blob/82421fd7053bf58dea69e9a259e6f2618c2be2e5/.github/workflows/nightlies.yml#L264 has bundled `dist/nimble`, but it only copies the data without `.git`. So in this PR, we ignore bundled nimble repo.
|
it works for nightlies now https://github.com/nim-lang/nightlies/actions/runs/12372413439 |
narimiran
pushed a commit
that referenced
this pull request
Dec 23, 2024
) follow up #24537 Because `nimble` is a bundled repo so it is bundled in the tarballs i.e. https://github.com/nim-lang/nightlies/blob/82421fd7053bf58dea69e9a259e6f2618c2be2e5/.github/workflows/nightlies.yml#L264 has bundled `dist/nimble`, but it only copies the data without `.git`. So in this PR, we ignore bundled nimble repo. (cherry picked from commit 70b3232)
narimiran
pushed a commit
that referenced
this pull request
Jan 14, 2025
narimiran
pushed a commit
that referenced
this pull request
Jan 15, 2025
) follow up #24537 Because `nimble` is a bundled repo so it is bundled in the tarballs i.e. https://github.com/nim-lang/nightlies/blob/82421fd7053bf58dea69e9a259e6f2618c2be2e5/.github/workflows/nightlies.yml#L264 has bundled `dist/nimble`, but it only copies the data without `.git`. So in this PR, we ignore bundled nimble repo. (cherry picked from commit 70b3232)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.