Make error appear in user code with invalid format string in strformat
#24528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Jan 14, 2025
…at` (#24528) With this example ```nim import std/strformat echo fmt"{invalid, code}" ``` We get the error message ``` stack trace: (most recent call last) /home/jake/.choosenim/toolchains/nim-hashdevel/lib/pure/strformat.nim(750, 16) fmt /home/jake/.choosenim/toolchains/nim-hashdevel/lib/pure/strformat.nim(714, 16) strformatImpl /home/jake/Documents/projects/Nim/temp.nim(3, 9) template/generic instantiation of `fmt` from here /home/jake/.choosenim/toolchains/nim-hashdevel/lib/pure/strformat.nim(714, 16) Error: could not parse `invalid, code` in `{invalid, code}`. (1, 8) Error: invalid indentation ``` After PR it now shortens it to just appear in user code ``` /home/jake/Documents/projects/Nim/lib/pure/strformat.nim(750, 16) fmt /home/jake/Documents/projects/Nim/lib/pure/strformat.nim(714, 16) strformatImpl /home/jake/Documents/projects/Nim/temp.nim(3, 9) Error: could not parse `invalid, code` in `{invalid, code}`. (1, 8) Error: invalid indentation ``` (cherry picked from commit da9f7f6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this example
We get the error message
After PR it now shortens it to just appear in user code