use cbuilder for most braced initializers #24259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
metagn
added a commit
to metagn/Nim
that referenced
this pull request
Oct 13, 2024
follows up nim-lang#24259
Araq
pushed a commit
that referenced
this pull request
Oct 14, 2024
follows up #24259 This was the only use of the `STRING_LITERAL` macro in `nimbase.h`, so this macro is now removed. We don't have to remove it though, maybe people use it.
metagn
added a commit
to metagn/Nim
that referenced
this pull request
Oct 15, 2024
Araq
pushed a commit
that referenced
this pull request
Oct 16, 2024
…ces (#24312) follows up #24259 This is the remaining missing use of `StructInitializer` in `getDefaultValue` after #24259 and #24302. The only remaining direct C code in getDefaultValue is [this line](https://github.com/nim-lang/Nim/blob/922f7dfd712130bb68a16336085c0320afceb273/compiler/ccgexprs.nim#L3525) which creates a global array variable, which isn't implemented yet. Next steps would be all remaining variable and `typedef` declarations, then hopefully we can move on to general statements and expressions.
Araq
pushed a commit
that referenced
this pull request
Oct 18, 2024
The remaining followup from #24259. A body for building the type doesn't seem necessary here since the types with array fields are generally atomic/already built from `getTypeDescAux`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StructInitializeris now used for most braced initializers in the C generation, mostly ingenBracedInit,getNullValueAux,getDefaultValue. The exceptions are:StructInitializeryet (siNamedStruct)ccgliteralsare untouched so all of ccgliterals can be done separately and in 1 goThere is one case where
genBracedInitdoes not use cbuilder, which is the global literal variable for openarrays. The reason for this is simply that variables with C array type are not implemented, which I thought would be best to leave out of this PR.For the simplicity of the implementation, code in
getNullValueAuxTthat reset the initializer back to its initial state if theSupfield did not have any fields itself, is now disabled. This was so the compiler does not generate{}for the Sup field, i.e.{{}}, but every call togetNullValueAuxTstill generates{}if the struct doesn't have any fields, so I don't know if it really breaks anything. The case where the Sup field doesn't have any fields but the struct does also would have generated{{}, field}.Worst case, we can implement either the "resetting" or just disable the generation of the
Supfield if there are no fields total. But a better fix might be to always generate{0}if the struct has no fields, in line with thechar dummyfield that gets added for all objects with no fields. This doesn't seem necessary for now but might be for the NIFC output, in which case we can probably keep the logic contained inside cbuilder (if no fields generated forsiOrderedStruct/siNamedStruct, we add a0for thedummyfield). This would stipulate that all uses of struct initializers are exhaustive for every field in structs.