Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc: move object equality out of system using macro #24220

Closed
wants to merge 5 commits into from

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Oct 3, 2024

refs nim-lang/RFCs#475, refs #6676

Want to see how much this breaks, should have tried it sooner

@metagn
Copy link
Collaborator Author

metagn commented Oct 6, 2024

Well it works, but it's a bit late to tie this into nimPreviewSlimSystem and there's very little discussion about it. I copied the implementation straight from my comment on #6676, I'm not sure if it's up to date, derivative implementation is on skinsuit.

It would be nice if we could add the module by itself but it really only works if we also remove the original symbol from the system module. Maybe another flag than nimPreviewSlimSystem but having more than 1 preview flag could make things worse and hard to track, unless we give a proper timeframe for them, i.e. guarantee that nimPreviewObjectEquals is only made default strictly after nimPreviewSlimSystem is.

An alternative would be implementing nim-lang/RFCs#367 but I figured this would kill two birds with one stone. (I also don't want to touch fields but tuple equality still needs it.)

@metagn metagn changed the title test moving object equality out of system, using macro poc: move object equality out of system using macro Feb 15, 2025
@metagn metagn closed this Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant